ERL-467: nemos-images-reference-*: *: add checkbox-erlangen-classic snap #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #54 |
IsaacJT
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
from
cb4da73
to
1ea8512
Compare
Add the custom Checkbox snap created for the project. This contains all of the project-specific test suites that we require. Signed-off-by: Isaac True <isaac.true@canonical.com>
IsaacJT
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
from
1ea8512
to
c7c915b
Compare
Signed-off-by: Isaac True <isaac.true@canonical.com>
IsaacJT
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
from
a05e2f8
to
5b40ccc
Compare
ahresse
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Works for me on development profile for mantic reference image.
# snap list checkbox-erlangen-classic
Name Version Rev Tracking Publisher Notes
checkbox-erlangen-classic 0.1dev 2 latest/stable ce-certification-qa classic
Thank you Isaac for adding spread tests.
IsaacJT
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
5 times, most recently
from
ba9e839
to
53dfaee
Compare
If building a "reference" image, we want to use the development profile in order to include all snaps. Signed-off-by: Isaac True <isaac.true@canonical.com>
… installed Signed-off-by: Isaac True <isaac.true@canonical.com>
Signed-off-by: Isaac True <isaac.true@canonical.com>
IsaacJT
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
from
53dfaee
to
211d75b
Compare
|
CI fixed |
zongminl
suggested changes
Nov 27, 2023
Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
…pendency `checkbox` snap has launchers built-in but the one we use are in `checkbox-erlangen-classic` which has launchers and providers (in checkbox term, the jobs and testplans), but doesn't have checkbox-runtime so we still depend on `checkbox22` to provide the service and also the generic providers. Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
ahresse
force-pushed
the
ERL-467-add-checkbox-erlangen
branch
from
93053e6
to
a73372a
Compare
|
LGTM, thanks for the additions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the custom Checkbox snap created for the project. This contains all of the project-specific test suites that we require.